From 08edcf6a7954da882aee4218e6e8d974f2848f02 Mon Sep 17 00:00:00 2001 From: peter Date: Thu, 20 Dec 2018 14:47:13 +0100 Subject: [PATCH] ActionSetBuilder: don't invoke update right after we already updated the actions (IDEA-204405) --- .../src/com/intellij/ui/popup/ActionStepBuilder.java | 9 --------- 1 file changed, 9 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/ui/popup/ActionStepBuilder.java b/platform/platform-impl/src/com/intellij/ui/popup/ActionStepBuilder.java index b56ec5bd13e8..a920a5d61b12 100644 --- a/platform/platform-impl/src/com/intellij/ui/popup/ActionStepBuilder.java +++ b/platform/platform-impl/src/com/intellij/ui/popup/ActionStepBuilder.java @@ -2,10 +2,8 @@ package com.intellij.ui.popup; import com.intellij.openapi.actionSystem.*; -import com.intellij.openapi.actionSystem.ex.ActionUtil; import com.intellij.openapi.actionSystem.impl.PresentationFactory; import com.intellij.openapi.actionSystem.impl.Utils; -import com.intellij.openapi.application.impl.LaterInvocator; import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.util.IconLoader; import com.intellij.ui.SizedIcon; @@ -113,10 +111,6 @@ public class ActionStepBuilder extends PresentationFactory { private void appendActionsFromGroup(@NotNull ActionGroup actionGroup) { List newVisibleActions = Utils.expandActionGroup(false, actionGroup, this, myDataContext, myActionPlace); for (AnAction action : newVisibleActions) { - if (action == null) { - LOG.error("null action in group " + actionGroup); - continue; - } if (action instanceof Separator) { myPrependWithSeparator = true; mySeparatorText = ((Separator)action).getText(); @@ -129,9 +123,6 @@ public class ActionStepBuilder extends PresentationFactory { private void appendAction(@NotNull AnAction action) { Presentation presentation = getPresentation(action); - AnActionEvent event = createActionEvent(action); - - ActionUtil.performDumbAwareUpdate(LaterInvocator.isInModalContext(), action, event, true); boolean enabled = presentation.isEnabled(); if ((myShowDisabled || enabled) && presentation.isVisible()) { String text = presentation.getText();