From 07586a4bee85c5f8414ce0c711a8c2b12e5c94b4 Mon Sep 17 00:00:00 2001
From: Eugene Kudelevsky <Eugene.Kudelevsky@jetbrains.com>
Date: Mon, 18 Jun 2012 20:42:53 +0400
Subject: [PATCH] android+maven: error about 'apksources' dependency

---
 .../android/maven/AndroidFacetImporterBase.java   | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/plugins/android/src/org/jetbrains/android/maven/AndroidFacetImporterBase.java b/plugins/android/src/org/jetbrains/android/maven/AndroidFacetImporterBase.java
index c21fe0b33e11..4d36d8c7fadd 100644
--- a/plugins/android/src/org/jetbrains/android/maven/AndroidFacetImporterBase.java
+++ b/plugins/android/src/org/jetbrains/android/maven/AndroidFacetImporterBase.java
@@ -18,6 +18,9 @@ package org.jetbrains.android.maven;
 import com.android.sdklib.IAndroidTarget;
 import com.intellij.facet.FacetType;
 import com.intellij.ide.highlighter.ModuleFileType;
+import com.intellij.notification.Notification;
+import com.intellij.notification.NotificationType;
+import com.intellij.notification.Notifications;
 import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.module.ModifiableModuleModel;
@@ -107,12 +110,20 @@ public abstract class AndroidFacetImporterBase extends FacetImporter<AndroidFace
     String mavenProjectDirPath = FileUtil.toSystemIndependentName(mavenProject.getDirectory());
     facet.getConfiguration().init(facet.getModule(), mavenProjectDirPath);
     AndroidMavenProviderImpl.setPathsToDefault(mavenProject, facet.getModule(), facet.getConfiguration());
-    AndroidMavenProviderImpl.configureAaptCompilation(mavenProject, facet.getModule(), facet.getConfiguration(),
-                                                      AndroidMavenProviderImpl.hasApkSourcesDependency(mavenProject));
+
+    final boolean hasApkSources = AndroidMavenProviderImpl.hasApkSourcesDependency(mavenProject);
+    AndroidMavenProviderImpl.configureAaptCompilation(mavenProject, facet.getModule(), facet.getConfiguration(), hasApkSources);
 
     if (AndroidMavenUtil.APKLIB_DEPENDENCY_AND_PACKAGING_TYPE.equals(mavenProject.getPackaging())) {
       facet.getConfiguration().LIBRARY_PROJECT = true;
     }
+
+    if (hasApkSources) {
+      Notifications.Bus.notify(new Notification("Importing Error", "Error when importing module " + facet.getModule().getName(),
+                                                "'apksources' dependency is deprecated and can be poorly supported by IDE. " +
+                                                "It is strongly recommended to use 'apklib' dependency instead.",
+                                                NotificationType.ERROR, null));
+    }
   }
 
   @Override