From 07054be059ee8ece726e44e6c14ab05f5e14a499 Mon Sep 17 00:00:00 2001 From: Mikhail Golubev Date: Thu, 18 Jul 2019 14:04:28 +0300 Subject: [PATCH] PY-36884 Duplicate progress messages in logs, log whenever a skeleton is cleaned up This will help to diagnose why some of the skeletons are absent in case something similar happens again. GitOrigin-RevId: 9f67aaeede13008773255fcd39ae69c042ca1eb1 --- .../jetbrains/python/sdk/skeletons/PySkeletonRefresher.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python/src/com/jetbrains/python/sdk/skeletons/PySkeletonRefresher.java b/python/src/com/jetbrains/python/sdk/skeletons/PySkeletonRefresher.java index 2987fa3a7623..c729c7e7c2cb 100644 --- a/python/src/com/jetbrains/python/sdk/skeletons/PySkeletonRefresher.java +++ b/python/src/com/jetbrains/python/sdk/skeletons/PySkeletonRefresher.java @@ -204,6 +204,7 @@ public class PySkeletonRefresher { } private void indicate(String msg) { + LOG.debug("Progress message: " + msg); if (myIndicator != null) { myIndicator.checkCanceled(); myIndicator.setText(msg); @@ -212,6 +213,7 @@ public class PySkeletonRefresher { } private void indicateMinor(String msg) { + LOG.debug("Progress message (minor): " + msg); if (myIndicator != null) { myIndicator.setText2(msg); } @@ -586,14 +588,16 @@ public class PySkeletonRefresher { continue; } final SkeletonHeader header = readSkeletonHeader(item); + String binaryFile = null; boolean canLive = header != null; if (canLive) { - final String binaryFile = header.getBinaryFile(); + binaryFile = header.getBinaryFile(); canLive = SkeletonVersionChecker.PREGENERATED.equals(binaryFile) || SkeletonVersionChecker.BUILTIN_NAME.equals(binaryFile) || mySkeletonsGenerator.exists(binaryFile); } if (!canLive) { + LOG.debug("Cleaning up skeleton " + item + (binaryFile != null ? " for non existing binary " + binaryFile : "")); mySkeletonsGenerator.deleteOrLog(item); } }