From 062fcda742e52a02a45ca6ea4c3e4875015a1a29 Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Fri, 6 Nov 2015 16:13:59 +0100 Subject: [PATCH] fix unsorted array search --- .../structuralsearch/JavaStructuralSearchProfile.java | 3 ++- .../idea/eclipse/conversion/EclipseClasspathWriter.java | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/java/structuralsearch-java/src/com/intellij/structuralsearch/JavaStructuralSearchProfile.java b/java/structuralsearch-java/src/com/intellij/structuralsearch/JavaStructuralSearchProfile.java index b2b44aebd867..d79eb59219c5 100644 --- a/java/structuralsearch-java/src/com/intellij/structuralsearch/JavaStructuralSearchProfile.java +++ b/java/structuralsearch-java/src/com/intellij/structuralsearch/JavaStructuralSearchProfile.java @@ -32,6 +32,7 @@ import com.intellij.structuralsearch.plugin.replace.impl.Replacer; import com.intellij.structuralsearch.plugin.ui.Configuration; import com.intellij.structuralsearch.plugin.ui.SearchContext; import com.intellij.structuralsearch.plugin.ui.UIUtil; +import com.intellij.util.ArrayUtil; import com.intellij.util.IncorrectOperationException; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -382,7 +383,7 @@ public class JavaStructuralSearchProfile extends StructuralSearchProfile { private void checkModifier(final String name) { if (!MatchOptions.INSTANCE_MODIFIER_NAME.equals(name) && !PsiModifier.PACKAGE_LOCAL.equals(name) && - Arrays.binarySearch(JavaMatchingVisitor.MODIFIERS, name) < 0 + ArrayUtil.find(JavaMatchingVisitor.MODIFIERS, name) < 0 ) { throw new MalformedPatternException(SSRBundle.message("invalid.modifier.type",name)); } diff --git a/plugins/eclipse/src/org/jetbrains/idea/eclipse/conversion/EclipseClasspathWriter.java b/plugins/eclipse/src/org/jetbrains/idea/eclipse/conversion/EclipseClasspathWriter.java index 27e576979158..892b7e55291f 100644 --- a/plugins/eclipse/src/org/jetbrains/idea/eclipse/conversion/EclipseClasspathWriter.java +++ b/plugins/eclipse/src/org/jetbrains/idea/eclipse/conversion/EclipseClasspathWriter.java @@ -28,6 +28,7 @@ import com.intellij.openapi.util.Comparing; import com.intellij.openapi.util.text.StringUtil; import com.intellij.openapi.vfs.VfsUtilCore; import com.intellij.openapi.vfs.VirtualFile; +import com.intellij.util.ArrayUtil; import com.intellij.util.Function; import gnu.trove.THashMap; import org.jdom.Element; @@ -39,7 +40,6 @@ import org.jetbrains.idea.eclipse.EclipseXml; import org.jetbrains.idea.eclipse.IdeaXml; import org.jetbrains.idea.eclipse.config.EclipseModuleManagerImpl; -import java.util.Arrays; import java.util.Map; public class EclipseClasspathWriter { @@ -90,7 +90,7 @@ public class EclipseClasspathWriter { private void createClasspathEntry(@NotNull OrderEntry entry, @NotNull Element classpathRoot, @NotNull final ModuleRootModel model) throws ConversionException { EclipseModuleManager eclipseModuleManager = EclipseModuleManagerImpl.getInstance(entry.getOwnerModule()); if (entry instanceof ModuleSourceOrderEntry) { - boolean shouldPlaceSeparately = eclipseModuleManager.isExpectedModuleSourcePlace(Arrays.binarySearch(model.getOrderEntries(), entry)); + boolean shouldPlaceSeparately = eclipseModuleManager.isExpectedModuleSourcePlace(ArrayUtil.find(model.getOrderEntries(), entry)); for (ContentEntry contentEntry : model.getContentEntries()) { VirtualFile contentRoot = contentEntry.getFile(); for (SourceFolder sourceFolder : contentEntry.getSourceFolders()) {