From 06166d1382a02ec7ff18d55f9deceb30e16ef87c Mon Sep 17 00:00:00 2001
From: "Ilya.Kazakevich" <Ilya.Kazakevich@jetbrains.com>
Date: Wed, 30 May 2018 01:36:27 +0300
Subject: [PATCH] PY-30032: Provide fixture names as arguments to tests

def test_sample(Fixture must be provided here):
    pass
---
 python/src/META-INF/python-core-common.xml    |  2 +
 .../PyTestFixtureCompletionContributor.kt     | 45 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 python/src/com/jetbrains/python/testing/pyTestFixtures/PyTestFixtureCompletionContributor.kt

diff --git a/python/src/META-INF/python-core-common.xml b/python/src/META-INF/python-core-common.xml
index f682b4445c94..cb711e9b09fe 100644
--- a/python/src/META-INF/python-core-common.xml
+++ b/python/src/META-INF/python-core-common.xml
@@ -67,6 +67,8 @@
     <extendWordSelectionHandler implementation="com.jetbrains.python.editor.selectWord.PyCommaSelectionHandler"/>
     <basicWordSelectionFilter implementation="com.jetbrains.python.editor.selectWord.PyBasicWordSelectionFilter"/>
     <stripTrailingSpacesFilterFactory implementation="com.jetbrains.python.editor.PyStripTrailingSpacesFilterFactory"/>
+    <completion.contributor language="Python"
+                            implementationClass="com.jetbrains.python.testing.pyTestFixtures.PyTestFixtureCompletionContributor"/>
     <completion.contributor language="Python"
                             implementationClass="com.jetbrains.python.codeInsight.completion.PyKeywordCompletionContributor"/>
     <completion.contributor language="Python"
diff --git a/python/src/com/jetbrains/python/testing/pyTestFixtures/PyTestFixtureCompletionContributor.kt b/python/src/com/jetbrains/python/testing/pyTestFixtures/PyTestFixtureCompletionContributor.kt
new file mode 100644
index 000000000000..535d93a36708
--- /dev/null
+++ b/python/src/com/jetbrains/python/testing/pyTestFixtures/PyTestFixtureCompletionContributor.kt
@@ -0,0 +1,45 @@
+package com.jetbrains.python.testing.pyTestFixtures
+
+import com.intellij.codeInsight.completion.*
+import com.intellij.openapi.module.ModuleUtilCore
+import com.intellij.patterns.PlatformPatterns
+import com.intellij.psi.util.PsiTreeUtil
+import com.intellij.util.ProcessingContext
+import com.intellij.util.ThreeState
+import com.jetbrains.python.PyNames
+import com.jetbrains.python.codeInsight.completion.PythonLookupElement
+import com.jetbrains.python.psi.PyParameterList
+import com.jetbrains.python.psi.types.TypeEvalContext
+import com.jetbrains.python.testing.PyTestFrameworkService
+import com.jetbrains.python.testing.TestRunnerService
+import com.jetbrains.python.testing.isTestElement
+import icons.PythonIcons
+
+private val pyTestName = PyTestFrameworkService.getSdkReadableNameByFramework(PyNames.PY_TEST)
+
+private object PyTestFixtureCompletionProvider : CompletionProvider<CompletionParameters>() {
+  override fun addCompletions(parameters: CompletionParameters, context: ProcessingContext?, result: CompletionResultSet) {
+    val pyFunction = PsiTreeUtil.getParentOfType(parameters.position, PyParameterList::class.java)?.containingFunction ?: return
+    val module = ModuleUtilCore.findModuleForPsiElement(pyFunction) ?: return
+    val typeEvalContext = TypeEvalContext.userInitiated(pyFunction.project, pyFunction.containingFile)
+
+    if (TestRunnerService.getInstance(module).projectConfiguration != pyTestName) {
+      return
+    }
+    val usedParams = pyFunction.getParameters(typeEvalContext).mapNotNull { it.name }.toSet()
+    if (isTestElement(pyFunction, ThreeState.UNSURE, typeEvalContext)) {
+      getFixtures(module).map { it.name }.filter { !usedParams.contains(it) }.forEach {
+        result.addElement(PythonLookupElement(it, false, PythonIcons.Python.Function))
+      }
+    }
+  }
+}
+
+/**
+ * Provide pytest fixtures are possible arguments for tests
+ */
+class PyTestFixtureCompletionContributor : CompletionContributor() {
+  init {
+    extend(CompletionType.BASIC, PlatformPatterns.psiElement().inside(PyParameterList::class.java), PyTestFixtureCompletionProvider)
+  }
+}