From 00eb5054971510115bd12f40b6560b0ee5cebc6f Mon Sep 17 00:00:00 2001 From: Semyon Proshev Date: Fri, 16 Oct 2020 12:33:29 +0300 Subject: [PATCH] Python 2.6 is no more supported in compatibility inspection Because 2.6 is not supported since 2019.1 in IDE. GitOrigin-RevId: 3dee3e941c921ad3a5dc6d72cca840eb5d811691 --- .../PyCompatibilityInspection.java | 2 +- .../argumentsUnpackingGeneralizations.py | 14 ++-- .../assignmentExpressions.py | 8 +- .../PyCompatibilityInspection/asyncAwait.py | 12 +-- .../asyncComprehensions.py | 4 +- .../awaitInComprehensions.py | 26 +++---- .../callExpression.py | 2 +- .../doubleStarUnpacking.py | 2 +- .../ellipsisAsStatementPy2.py | 2 +- .../equalitySignInFStrings.py | 4 +- .../expressionInDecorators.py | 4 +- .../importElement.py | 2 +- .../importStatement.py | 2 +- .../PyCompatibilityInspection/matMul.py | 4 +- .../PyCompatibilityInspection/raiseFrom.py | 2 +- .../starExpression.py | 4 +- .../stringLiteralExpression.py | 28 +++---- .../trailingCommaAfterStarArgs.py | 4 +- .../tryFinallyEmptyRaisePy2.py | 2 +- .../tryFinallyEmptyRaisePy3.py | 2 +- .../underscoreBz2Module.py | 2 +- .../underscoresInNumericLiterals.py | 74 +++++++++---------- ...nNonParenthesizedTuplesInReturnAndYield.py | 6 +- .../variableAnnotations.py | 10 +-- .../yieldInsideAsyncDef.py | 6 +- .../PyCompatibilityInspectionTest.java | 4 +- 26 files changed, 116 insertions(+), 116 deletions(-) diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java index ee6a2f454e04..bd1d7b10608c 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java @@ -74,7 +74,7 @@ public class PyCompatibilityInspection extends PyInspection { @NotNull public static final List SUPPORTED_LEVELS = StreamEx .of(LanguageLevel.values()) - .filter(v -> v.isPython2() && v.isAtLeast(LanguageLevel.PYTHON26) || v.isAtLeast(LanguageLevel.PYTHON35)) + .filter(v -> v == LanguageLevel.PYTHON27 || v.isAtLeast(LanguageLevel.PYTHON35)) .toImmutableList(); @NotNull diff --git a/python/testData/inspections/PyCompatibilityInspection/argumentsUnpackingGeneralizations.py b/python/testData/inspections/PyCompatibilityInspection/argumentsUnpackingGeneralizations.py index 2f784bc1219c..2a6dce786198 100644 --- a/python/testData/inspections/PyCompatibilityInspection/argumentsUnpackingGeneralizations.py +++ b/python/testData/inspections/PyCompatibilityInspection/argumentsUnpackingGeneralizations.py @@ -4,14 +4,14 @@ def foo(*args, **kwargs): foo(0, *[1], - 2, - *[3], - 4, + 2, + *[3], + 4, a='a', - *[6], + *[6], b='b', - *[7], + *[7], c='c', **{'d': 'd'}, - e='e', - **{'f': 'f'}) + e='e', + **{'f': 'f'}) diff --git a/python/testData/inspections/PyCompatibilityInspection/assignmentExpressions.py b/python/testData/inspections/PyCompatibilityInspection/assignmentExpressions.py index 69787fb729eb..678259eb64da 100644 --- a/python/testData/inspections/PyCompatibilityInspection/assignmentExpressions.py +++ b/python/testData/inspections/PyCompatibilityInspection/assignmentExpressions.py @@ -1,13 +1,13 @@ # Handle a matched regex -if (match := pattern.search(data)) is not None: +if (match := pattern.search(data)) is not None: pass # A loop that can't be trivially rewritten using 2-arg iter() -while chunk := file.read(8192): +while chunk := file.read(8192): pass # Reuse a value that's expensive to compute -[y := f(x), y**2, y**3] +[y := f(x), y**2, y**3] # Share a subexpression between a comprehension filter clause and its output -filtered_data = [y for x in data if (y := f(x)) is not None] \ No newline at end of file +filtered_data = [y for x in data if (y := f(x)) is not None] \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/asyncAwait.py b/python/testData/inspections/PyCompatibilityInspection/asyncAwait.py index 6bba8af348b1..803427817541 100644 --- a/python/testData/inspections/PyCompatibilityInspection/asyncAwait.py +++ b/python/testData/inspections/PyCompatibilityInspection/asyncAwait.py @@ -1,7 +1,7 @@ -async def foo(x): - async with x: - y = await x - if await y: - return await z - async for y in x: +async def foo(x): + async with x: + y = await x + if await y: + return await z + async for y in x: pass diff --git a/python/testData/inspections/PyCompatibilityInspection/asyncComprehensions.py b/python/testData/inspections/PyCompatibilityInspection/asyncComprehensions.py index 728c1908c0d5..d57c75b94e30 100644 --- a/python/testData/inspections/PyCompatibilityInspection/asyncComprehensions.py +++ b/python/testData/inspections/PyCompatibilityInspection/asyncComprehensions.py @@ -1,6 +1,6 @@ -async def asyncgen(): +async def asyncgen(): yield 10 -async def run(): +async def run(): {i async for i in asyncgen()} [i async for i in asyncgen()] {i: i ** 2 async for i in asyncgen()} diff --git a/python/testData/inspections/PyCompatibilityInspection/awaitInComprehensions.py b/python/testData/inspections/PyCompatibilityInspection/awaitInComprehensions.py index be2a98feb5aa..af500db39e43 100644 --- a/python/testData/inspections/PyCompatibilityInspection/awaitInComprehensions.py +++ b/python/testData/inspections/PyCompatibilityInspection/awaitInComprehensions.py @@ -1,16 +1,16 @@ -async def async2(): - [await fun() for fun in funcs] - {await fun() for fun in funcs} - {fun: await fun() for fun in funcs} +async def async2(): + [await fun() for fun in funcs] + {await fun() for fun in funcs} + {fun: await fun() for fun in funcs} - [await fun() for fun in funcs if await smth] - {await fun() for fun in funcs if await smth} - {fun: await fun() for fun in funcs if await smth} + [await fun() for fun in funcs if await smth] + {await fun() for fun in funcs if await smth} + {fun: await fun() for fun in funcs if await smth} - [await fun() async for fun in funcs] - {await fun() async for fun in funcs} - {fun: await fun() async for fun in funcs} + [await fun() async for fun in funcs] + {await fun() async for fun in funcs} + {fun: await fun() async for fun in funcs} - [await fun() async for fun in funcs if await smth] - {await fun() async for fun in funcs if await smth} - {fun: await fun() async for fun in funcs if await smth} \ No newline at end of file + [await fun() async for fun in funcs if await smth] + {await fun() async for fun in funcs if await smth} + {fun: await fun() async for fun in funcs if await smth} \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/callExpression.py b/python/testData/inspections/PyCompatibilityInspection/callExpression.py index 0e10186dd528..ce3ac1888c99 100644 --- a/python/testData/inspections/PyCompatibilityInspection/callExpression.py +++ b/python/testData/inspections/PyCompatibilityInspection/callExpression.py @@ -1,6 +1,6 @@ class A(B): def __init__(self): - super() + super() cmp() reduce() diff --git a/python/testData/inspections/PyCompatibilityInspection/doubleStarUnpacking.py b/python/testData/inspections/PyCompatibilityInspection/doubleStarUnpacking.py index c86267f740bf..136ec73b7baf 100644 --- a/python/testData/inspections/PyCompatibilityInspection/doubleStarUnpacking.py +++ b/python/testData/inspections/PyCompatibilityInspection/doubleStarUnpacking.py @@ -1,2 +1,2 @@ xs = {1: 2} -ys = {**xs, 3: 4} +ys = {**xs, 3: 4} diff --git a/python/testData/inspections/PyCompatibilityInspection/ellipsisAsStatementPy2.py b/python/testData/inspections/PyCompatibilityInspection/ellipsisAsStatementPy2.py index df4ebc0fe8d0..66e97d34d7c4 100644 --- a/python/testData/inspections/PyCompatibilityInspection/ellipsisAsStatementPy2.py +++ b/python/testData/inspections/PyCompatibilityInspection/ellipsisAsStatementPy2.py @@ -1,2 +1,2 @@ def foo(): - ... + ... diff --git a/python/testData/inspections/PyCompatibilityInspection/equalitySignInFStrings.py b/python/testData/inspections/PyCompatibilityInspection/equalitySignInFStrings.py index 4f9133421222..81af01e50c12 100644 --- a/python/testData/inspections/PyCompatibilityInspection/equalitySignInFStrings.py +++ b/python/testData/inspections/PyCompatibilityInspection/equalitySignInFStrings.py @@ -1,3 +1,3 @@ import math -print(f'{math.pi =:.2f}') -print(f'{f"{3.1415=:.1f}":*^20}') \ No newline at end of file +print(f'{math.pi =:.2f}') +print(f'{f"{3.1415=:.1f}":*^20}') \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/expressionInDecorators.py b/python/testData/inspections/PyCompatibilityInspection/expressionInDecorators.py index 18926ebb58bb..45e37df3772a 100644 --- a/python/testData/inspections/PyCompatibilityInspection/expressionInDecorators.py +++ b/python/testData/inspections/PyCompatibilityInspection/expressionInDecorators.py @@ -1,9 +1,9 @@ -@x[0][1] +@x[0][1] @my_decorator def say_whee(): print("Whee!") -@foo[0].wrapper +@foo[0].wrapper @foo.bar() def say_whee(): print("Whee!") \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/importElement.py b/python/testData/inspections/PyCompatibilityInspection/importElement.py index 9b7c598b7449..60ca2c08ea7b 100644 --- a/python/testData/inspections/PyCompatibilityInspection/importElement.py +++ b/python/testData/inspections/PyCompatibilityInspection/importElement.py @@ -1,4 +1,4 @@ import Bastion -from asyncio import Queue +from asyncio import Queue from io import StringIO \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/importStatement.py b/python/testData/inspections/PyCompatibilityInspection/importStatement.py index dda1caaaedbf..d3e3d7957424 100644 --- a/python/testData/inspections/PyCompatibilityInspection/importStatement.py +++ b/python/testData/inspections/PyCompatibilityInspection/importStatement.py @@ -1,3 +1,3 @@ -import builtins +import builtins import __builtin__ \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/matMul.py b/python/testData/inspections/PyCompatibilityInspection/matMul.py index 99364249aa1f..abd9b311c41b 100644 --- a/python/testData/inspections/PyCompatibilityInspection/matMul.py +++ b/python/testData/inspections/PyCompatibilityInspection/matMul.py @@ -1,2 +1,2 @@ -x @ y -x @= y +x @ y +x @= y diff --git a/python/testData/inspections/PyCompatibilityInspection/raiseFrom.py b/python/testData/inspections/PyCompatibilityInspection/raiseFrom.py index d09bdf87c7fb..aa6f260f55fb 100644 --- a/python/testData/inspections/PyCompatibilityInspection/raiseFrom.py +++ b/python/testData/inspections/PyCompatibilityInspection/raiseFrom.py @@ -1,2 +1,2 @@ -raise exception from cause +raise exception from cause a = 1 \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/starExpression.py b/python/testData/inspections/PyCompatibilityInspection/starExpression.py index 68e3d2a021ae..e91604fba3ee 100644 --- a/python/testData/inspections/PyCompatibilityInspection/starExpression.py +++ b/python/testData/inspections/PyCompatibilityInspection/starExpression.py @@ -1,2 +1,2 @@ -t = (1, *(2, 3)) -a, *b, c = t +t = (1, *(2, 3)) +a, *b, c = t diff --git a/python/testData/inspections/PyCompatibilityInspection/stringLiteralExpression.py b/python/testData/inspections/PyCompatibilityInspection/stringLiteralExpression.py index 77b81c5bd61c..857bd6711db3 100644 --- a/python/testData/inspections/PyCompatibilityInspection/stringLiteralExpression.py +++ b/python/testData/inspections/PyCompatibilityInspection/stringLiteralExpression.py @@ -2,22 +2,22 @@ a = u"String" # Python 3.6 -a = f"" -a = F"" -a = rf"" -a = fr"" -a = fu"" -a = uf"" -a = bf"" -a = fb"" -a = ufr"" +a = f"" +a = F"" +a = rf"" +a = fr"" +a = fu"" +a = uf"" +a = bf"" +a = fb"" +a = ufr"" # python 3.3 a = u"" a = r"" a = b"" -a = rb"" +a = rb"" a = br"" # python 3.2, 3.1 @@ -48,9 +48,9 @@ a = u"" b"" b = r"" b"" -b = f"" b"" +b = f"" b"" # never was available -a = rr"" -a = bb"" -a = uu"" \ No newline at end of file +a = rr"" +a = bb"" +a = uu"" \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/trailingCommaAfterStarArgs.py b/python/testData/inspections/PyCompatibilityInspection/trailingCommaAfterStarArgs.py index 0dfe512412f0..ab6d6ac7e76d 100644 --- a/python/testData/inspections/PyCompatibilityInspection/trailingCommaAfterStarArgs.py +++ b/python/testData/inspections/PyCompatibilityInspection/trailingCommaAfterStarArgs.py @@ -2,5 +2,5 @@ def foo(*args, **kwargs): print(args, kwargs) -foo(1, 2, 3, *[3],) -foo(1, 2, 3, *[3], **{'d': 'd'},) +foo(1, 2, 3, *[3],) +foo(1, 2, 3, *[3], **{'d': 'd'},) diff --git a/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy2.py b/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy2.py index 896a230820a8..b068c87d6339 100644 --- a/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy2.py +++ b/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy2.py @@ -1,4 +1,4 @@ try: raise ValueError finally: - raise \ No newline at end of file + raise \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy3.py b/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy3.py index e68eccf7d1f3..9783dc6e482d 100644 --- a/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy3.py +++ b/python/testData/inspections/PyCompatibilityInspection/tryFinallyEmptyRaisePy3.py @@ -1,4 +1,4 @@ try: raise ValueError finally: - raise \ No newline at end of file + raise \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/underscoreBz2Module.py b/python/testData/inspections/PyCompatibilityInspection/underscoreBz2Module.py index 3514027b3be8..6555e89e35a4 100644 --- a/python/testData/inspections/PyCompatibilityInspection/underscoreBz2Module.py +++ b/python/testData/inspections/PyCompatibilityInspection/underscoreBz2Module.py @@ -1 +1 @@ -import _bz2 \ No newline at end of file +import _bz2 \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/underscoresInNumericLiterals.py b/python/testData/inspections/PyCompatibilityInspection/underscoresInNumericLiterals.py index 048b788330d4..3f508e3a3ed4 100644 --- a/python/testData/inspections/PyCompatibilityInspection/underscoresInNumericLiterals.py +++ b/python/testData/inspections/PyCompatibilityInspection/underscoresInNumericLiterals.py @@ -1,58 +1,58 @@ # hex -0xCAFE_F00D +0xCAFE_F00D # oct -0o1_23 -01_23 +0o1_23 +01_23 # bin -0b_0011_1111_0100_1110 +0b_0011_1111_0100_1110 # dec -10_000_000 +10_000_000 # pointfloat -10_00.00_23 -10_00. +10_00.00_23 +10_00. # exponentfloat -10_00.00_23e1_2 -10_00.00_23E1_2 -10_00.e1_2 -10_00.E1_2 +10_00.00_23e1_2 +10_00.00_23E1_2 +10_00.e1_2 +10_00.E1_2 -10_00.00_23e+1_2 -10_00.00_23E+1_2 -10_00.e+1_2 -10_00.E+1_2 +10_00.00_23e+1_2 +10_00.00_23E+1_2 +10_00.e+1_2 +10_00.E+1_2 -10_00.00_23e-1_2 -10_00.00_23E-1_2 -10_00.e-1_2 -10_00.E-1_2 +10_00.00_23e-1_2 +10_00.00_23E-1_2 +10_00.e-1_2 +10_00.E-1_2 -10_0000_23e1_2 -10_0000_23E1_2 -10_00e1_2 -10_00E1_2 +10_0000_23e1_2 +10_0000_23E1_2 +10_00e1_2 +10_00E1_2 -10_0000_23e+1_2 -10_0000_23E+1_2 -10_00e+1_2 -10_00E+1_2 +10_0000_23e+1_2 +10_0000_23E+1_2 +10_00e+1_2 +10_00E+1_2 -10_0000_23e-1_2 -10_0000_23E-1_2 -10_00e-1_2 -10_00E-1_2 +10_0000_23e-1_2 +10_0000_23E-1_2 +10_00e-1_2 +10_00E-1_2 # imag -10_00.00_23j -10_00.00_23J +10_00.00_23j +10_00.00_23J -10_00.00_23e1_2j -10_00.00_23e1_2J +10_00.00_23e1_2j +10_00.00_23e1_2J -10_000_000j -10_000_000J \ No newline at end of file +10_000_000j +10_000_000J \ No newline at end of file diff --git a/python/testData/inspections/PyCompatibilityInspection/unpackingInNonParenthesizedTuplesInReturnAndYield.py b/python/testData/inspections/PyCompatibilityInspection/unpackingInNonParenthesizedTuplesInReturnAndYield.py index a2448a79f50b..e3f3311f3973 100644 --- a/python/testData/inspections/PyCompatibilityInspection/unpackingInNonParenthesizedTuplesInReturnAndYield.py +++ b/python/testData/inspections/PyCompatibilityInspection/unpackingInNonParenthesizedTuplesInReturnAndYield.py @@ -1,7 +1,7 @@ def gen(xs): - yield 42, *xs - yield from 42, *xs + yield 42, *xs + yield from 42, *xs def func(xs): - return 42, *xs + return 42, *xs diff --git a/python/testData/inspections/PyCompatibilityInspection/variableAnnotations.py b/python/testData/inspections/PyCompatibilityInspection/variableAnnotations.py index 955c64f36d67..31260797df48 100644 --- a/python/testData/inspections/PyCompatibilityInspection/variableAnnotations.py +++ b/python/testData/inspections/PyCompatibilityInspection/variableAnnotations.py @@ -1,8 +1,8 @@ class C: - x: int - y: None = 42 + x: int + y: None = 42 def m(self, d): - x: List[bool] - d['foo']: str - (d['bar']): float + x: List[bool] + d['foo']: str + (d['bar']): float diff --git a/python/testData/inspections/PyCompatibilityInspection/yieldInsideAsyncDef.py b/python/testData/inspections/PyCompatibilityInspection/yieldInsideAsyncDef.py index 46493ff8da35..224c4b07da0d 100644 --- a/python/testData/inspections/PyCompatibilityInspection/yieldInsideAsyncDef.py +++ b/python/testData/inspections/PyCompatibilityInspection/yieldInsideAsyncDef.py @@ -1,5 +1,5 @@ -async def foo(x): - await x +async def foo(x): + await x yield x - yield from x + yield from x return x diff --git a/python/testSrc/com/jetbrains/python/inspections/PyCompatibilityInspectionTest.java b/python/testSrc/com/jetbrains/python/inspections/PyCompatibilityInspectionTest.java index bd5339676b62..19c0e279958a 100644 --- a/python/testSrc/com/jetbrains/python/inspections/PyCompatibilityInspectionTest.java +++ b/python/testSrc/com/jetbrains/python/inspections/PyCompatibilityInspectionTest.java @@ -213,7 +213,7 @@ public class PyCompatibilityInspectionTest extends PyInspectionTestCase { runWithLanguageLevel( LanguageLevel.PYTHON38, () -> doTestByText( - "def f(pos1, /, pos_or_kwd, *, kwd1):\n" + + "def f(pos1, /, pos_or_kwd, *, kwd1):\n" + " pass" ) ); @@ -232,7 +232,7 @@ public class PyCompatibilityInspectionTest extends PyInspectionTestCase { " try:\n" + " print(\"a\")\n" + " finally:\n" + - " continue") + " continue") ); }