From 28c9d495a01e017eb8de1e2ed725c86c7352caed Mon Sep 17 00:00:00 2001 From: BlackMATov Date: Wed, 9 Apr 2025 16:15:03 +0700 Subject: [PATCH 1/2] `create` methods should not be marked as nodiscard, because sometimes we want to just call ctors --- develop/singles/headers/meta.hpp/meta_all.hpp | 10 +++++----- headers/meta.hpp/meta_states.hpp | 8 ++++---- headers/meta.hpp/meta_types.hpp | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/develop/singles/headers/meta.hpp/meta_all.hpp b/develop/singles/headers/meta.hpp/meta_all.hpp index e372877..e2348ef 100644 --- a/develop/singles/headers/meta.hpp/meta_all.hpp +++ b/develop/singles/headers/meta.hpp/meta_all.hpp @@ -3007,7 +3007,7 @@ namespace meta_hpp [[nodiscard]] const variable_list& get_variables() const noexcept; template < typename... Args > - [[nodiscard]] uvalue create(Args&&... args) const; + uvalue create(Args&&... args) const; template < typename... Args > uvalue create_at(void* mem, Args&&... args) const; @@ -4120,10 +4120,10 @@ namespace meta_hpp // template < typename... Args > - [[nodiscard]] uvalue create(Args&&... args) const; + uvalue create(Args&&... args) const; template < typename... Args > - [[nodiscard]] uresult try_create(Args&&... args) const; + uresult try_create(Args&&... args) const; template < typename... Args > uvalue create_at(void* mem, Args&&... args) const; @@ -4146,10 +4146,10 @@ namespace meta_hpp // template < typename Iter > - [[nodiscard]] uvalue create_variadic(Iter first, Iter last) const; + uvalue create_variadic(Iter first, Iter last) const; template < typename Iter > - [[nodiscard]] uresult try_create_variadic(Iter first, Iter last) const; + uresult try_create_variadic(Iter first, Iter last) const; template < typename Iter > uvalue create_variadic_at(void* mem, Iter first, Iter last) const; diff --git a/headers/meta.hpp/meta_states.hpp b/headers/meta.hpp/meta_states.hpp index d71b72a..60cb753 100644 --- a/headers/meta.hpp/meta_states.hpp +++ b/headers/meta.hpp/meta_states.hpp @@ -74,10 +74,10 @@ namespace meta_hpp // template < typename... Args > - [[nodiscard]] uvalue create(Args&&... args) const; + uvalue create(Args&&... args) const; template < typename... Args > - [[nodiscard]] uresult try_create(Args&&... args) const; + uresult try_create(Args&&... args) const; template < typename... Args > uvalue create_at(void* mem, Args&&... args) const; @@ -100,10 +100,10 @@ namespace meta_hpp // template < typename Iter > - [[nodiscard]] uvalue create_variadic(Iter first, Iter last) const; + uvalue create_variadic(Iter first, Iter last) const; template < typename Iter > - [[nodiscard]] uresult try_create_variadic(Iter first, Iter last) const; + uresult try_create_variadic(Iter first, Iter last) const; template < typename Iter > uvalue create_variadic_at(void* mem, Iter first, Iter last) const; diff --git a/headers/meta.hpp/meta_types.hpp b/headers/meta.hpp/meta_types.hpp index 6aa5a2d..7f392bf 100644 --- a/headers/meta.hpp/meta_types.hpp +++ b/headers/meta.hpp/meta_types.hpp @@ -171,7 +171,7 @@ namespace meta_hpp [[nodiscard]] const variable_list& get_variables() const noexcept; template < typename... Args > - [[nodiscard]] uvalue create(Args&&... args) const; + uvalue create(Args&&... args) const; template < typename... Args > uvalue create_at(void* mem, Args&&... args) const; From 7aa0c0583684b97f54de5fd7dd45c5abcb35585d Mon Sep 17 00:00:00 2001 From: BlackMATov Date: Wed, 9 Apr 2025 16:22:35 +0700 Subject: [PATCH 2/2] fix Darwin CI --- develop/cmake/SetupTargets.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/develop/cmake/SetupTargets.cmake b/develop/cmake/SetupTargets.cmake index d68fff6..6e39a5d 100644 --- a/develop/cmake/SetupTargets.cmake +++ b/develop/cmake/SetupTargets.cmake @@ -14,6 +14,7 @@ target_compile_options(${PROJECT_NAME}.setup_targets INTERFACE -Wno-exit-time-destructors -Wno-global-constructors -Wno-padded + -Wno-poison-system-directories -Wno-switch-default -Wno-unknown-warning-option -Wno-unneeded-internal-declaration