From 4a6dff48a8a30f59d0dd0bc985f84736870cd51b Mon Sep 17 00:00:00 2001 From: BlackMATov Date: Tue, 31 Jan 2023 15:44:55 +0700 Subject: [PATCH] remove unnecessary hashed string ctor overloads --- develop/singles/headers/meta.hpp/meta_all.hpp | 8 +------- headers/meta.hpp/meta_base/hashed_string.hpp | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/develop/singles/headers/meta.hpp/meta_all.hpp b/develop/singles/headers/meta.hpp/meta_all.hpp index c42fea3..f2e5f94 100644 --- a/develop/singles/headers/meta.hpp/meta_all.hpp +++ b/develop/singles/headers/meta.hpp/meta_all.hpp @@ -573,15 +573,9 @@ namespace meta_hpp::detail hashed_string& operator=(hashed_string&&) = default; hashed_string& operator=(const hashed_string&) = default; - constexpr hashed_string(const char* str) noexcept - : hash_{fnv1a_hash(str)} {} - constexpr hashed_string(std::string_view str) noexcept : hash_{fnv1a_hash(str)} {} - hashed_string(const std::string& str) noexcept - : hash_{fnv1a_hash(str)} {} - constexpr void swap(hashed_string& other) noexcept { std::swap(hash_, other.hash_); } @@ -590,7 +584,7 @@ namespace meta_hpp::detail return hash_; } private: - std::size_t hash_{fnv1a_hash("")}; + std::size_t hash_{fnv1a_hash({})}; }; constexpr void swap(hashed_string& l, hashed_string& r) noexcept { diff --git a/headers/meta.hpp/meta_base/hashed_string.hpp b/headers/meta.hpp/meta_base/hashed_string.hpp index 611efbb..f612677 100644 --- a/headers/meta.hpp/meta_base/hashed_string.hpp +++ b/headers/meta.hpp/meta_base/hashed_string.hpp @@ -50,15 +50,9 @@ namespace meta_hpp::detail hashed_string& operator=(hashed_string&&) = default; hashed_string& operator=(const hashed_string&) = default; - constexpr hashed_string(const char* str) noexcept - : hash_{fnv1a_hash(str)} {} - constexpr hashed_string(std::string_view str) noexcept : hash_{fnv1a_hash(str)} {} - hashed_string(const std::string& str) noexcept - : hash_{fnv1a_hash(str)} {} - constexpr void swap(hashed_string& other) noexcept { std::swap(hash_, other.hash_); } @@ -67,7 +61,7 @@ namespace meta_hpp::detail return hash_; } private: - std::size_t hash_{fnv1a_hash("")}; + std::size_t hash_{fnv1a_hash({})}; }; constexpr void swap(hashed_string& l, hashed_string& r) noexcept {