From 2394c842d3f3d5218d1ef2e758da82dd1c913fd9 Mon Sep 17 00:00:00 2001 From: BlackMATov Date: Fri, 6 Aug 2021 08:34:46 +0700 Subject: [PATCH] move to github actions --- .appveyor.yml | 28 ----------- .github/workflows/coverage.yml | 16 ++++++ .github/workflows/darwin.yml | 24 +++++++++ .github/workflows/linux.yml | 31 ++++++++++++ .github/workflows/windows.yml | 23 +++++++++ .travis.yml | 89 ---------------------------------- CMakeLists.txt | 27 ++++++++++- README.md | 32 ++++++------ sources/curly.hpp/curly.cpp | 8 --- untests/CMakeLists.txt | 16 ++++-- untests/curly_tests.cpp | 8 +-- 11 files changed, 151 insertions(+), 151 deletions(-) delete mode 100644 .appveyor.yml create mode 100644 .github/workflows/coverage.yml create mode 100644 .github/workflows/darwin.yml create mode 100644 .github/workflows/linux.yml create mode 100644 .github/workflows/windows.yml delete mode 100644 .travis.yml diff --git a/.appveyor.yml b/.appveyor.yml deleted file mode 100644 index 2130e34..0000000 --- a/.appveyor.yml +++ /dev/null @@ -1,28 +0,0 @@ -image: - - Visual Studio 2017 - - Visual Studio 2019 - -platform: - - x86 - - x64 - -configuration: - - Release - -for: - -- - matrix: - only: - - platform: x86 - configuration: Release - build_script: - - .ci\build_windows_x86.bat - -- - matrix: - only: - - platform: x64 - configuration: Release - build_script: - - .ci\build_windows_x64.bat diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml new file mode 100644 index 0000000..09e95e1 --- /dev/null +++ b/.github/workflows/coverage.yml @@ -0,0 +1,16 @@ +name: coverage + +on: [push, pull_request] + +jobs: + build: + runs-on: macos-10.15 + name: "coverage" + steps: + - uses: actions/checkout@v2 + with: + submodules: recursive + - name: Install lcov by Homebrew + run: brew install lcov + - name: Build && Test && Upload + run: .ci/build_coverage.sh diff --git a/.github/workflows/darwin.yml b/.github/workflows/darwin.yml new file mode 100644 index 0000000..07e86ea --- /dev/null +++ b/.github/workflows/darwin.yml @@ -0,0 +1,24 @@ +name: darwin + +on: [push, pull_request] + +jobs: + build: + runs-on: ${{matrix.config.os}} + strategy: + fail-fast: false + matrix: + config: + # https://github.com/actions/virtual-environments/tree/main/images/macos + - { os: "macos-10.15", xcode: "10.3" } + - { os: "macos-10.15", xcode: "11.7" } + - { os: "macos-10.15", xcode: "12.4" } + name: "xcode-${{matrix.config.xcode}}" + steps: + - uses: actions/checkout@v2 + with: + submodules: recursive + - name: Select Xcode + run: sudo xcode-select --switch "/Applications/Xcode_${{matrix.config.xcode}}.app" + - name: Build && Test + run: .ci/build_darwin.sh diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml new file mode 100644 index 0000000..c785bc7 --- /dev/null +++ b/.github/workflows/linux.yml @@ -0,0 +1,31 @@ +name: linux + +on: [push, pull_request] + +jobs: + build: + runs-on: ${{matrix.config.os}} + strategy: + fail-fast: false + matrix: + config: + # https://github.com/actions/virtual-environments/tree/main/images/linux + - { os: "ubuntu-20.04", cc: "gcc-7", cxx: "g++-7" } + - { os: "ubuntu-20.04", cc: "gcc-8", cxx: "g++-8" } + - { os: "ubuntu-20.04", cc: "gcc-9", cxx: "g++-9" } + - { os: "ubuntu-20.04", cc: "gcc-10", cxx: "g++-10" } + - { os: "ubuntu-20.04", cc: "clang-7", cxx: "clang++-7" } + - { os: "ubuntu-20.04", cc: "clang-8", cxx: "clang++-8" } + - { os: "ubuntu-20.04", cc: "clang-9", cxx: "clang++-9" } + - { os: "ubuntu-20.04", cc: "clang-10", cxx: "clang++-10" } + name: "${{matrix.config.cxx}}" + steps: + - name: Setup + run: sudo apt-get -y install "${{matrix.config.cc}}" "${{matrix.config.cxx}}" + - name: Checkout + uses: actions/checkout@v2 + with: + submodules: recursive + - name: Build && Test + run: .ci/build_linux.sh + env: { CC: "${{matrix.config.cc}}", CXX: "${{matrix.config.cxx}}" } diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml new file mode 100644 index 0000000..1486034 --- /dev/null +++ b/.github/workflows/windows.yml @@ -0,0 +1,23 @@ +name: windows + +on: [push, pull_request] + +jobs: + build: + runs-on: ${{matrix.config.os}} + strategy: + fail-fast: false + matrix: + config: + # https://github.com/actions/virtual-environments/tree/main/images/win + - { os: "windows-2016", vs: "Visual Studio 2017", arch: "x86" } + - { os: "windows-2016", vs: "Visual Studio 2017", arch: "x64" } + - { os: "windows-2019", vs: "Visual Studio 2019", arch: "x86" } + - { os: "windows-2019", vs: "Visual Studio 2019", arch: "x64" } + name: "${{matrix.config.vs}} ${{matrix.config.arch}}" + steps: + - uses: actions/checkout@v2 + with: + submodules: recursive + - name: Build && Test + run: .ci\build_windows_${{matrix.config.arch}}.bat diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 43462e1..0000000 --- a/.travis.yml +++ /dev/null @@ -1,89 +0,0 @@ -git: - depth: false - quiet: true - -language: cpp - -jobs: - include: - - # - # linux (g++) - # - - - os: linux - dist: bionic - stage: linux - name: g++-7 - addons: { apt: { sources: ["ubuntu-toolchain-r-test"], packages: ["g++-7"] } } - env: CC=gcc-7 CXX=g++-7 - script: .ci/build_linux.sh - - - os: linux - dist: bionic - stage: linux - name: g++-8 - addons: { apt: { sources: ["ubuntu-toolchain-r-test"], packages: ["g++-8"] } } - env: CC=gcc-8 CXX=g++-8 - script: .ci/build_linux.sh - - # - # linux (clang++) - # - - - os: linux - dist: bionic - stage: linux - name: clang++-5.0 - addons: { apt: { sources: ["ubuntu-toolchain-r-test"], packages: ["clang-5.0"] } } - env: CC=clang-5.0 CXX=clang++-5.0 - script: .ci/build_linux.sh - - - os: linux - dist: bionic - stage: linux - name: clang++-6.0 - addons: { apt: { sources: ["ubuntu-toolchain-r-test"], packages: ["clang-6.0"] } } - env: CC=clang-6.0 CXX=clang++-6.0 - script: .ci/build_linux.sh - - # - # darwin - # - - - os: osx - osx_image: xcode10 - stage: darwin - name: xcode10 - script: .ci/build_darwin.sh - - - os: osx - osx_image: xcode11 - stage: darwin - name: xcode11 - script: .ci/build_darwin.sh - - # - # windows - # - - - os: windows - stage: windows - name: x86 - script: .ci/build_windows_x86.bat - - - os: windows - stage: windows - name: x64 - script: .ci/build_windows_x64.bat - - # - # coverage - # - - - os: osx - osx_image: xcode10 - stage: coverage - name: coverage - addons: { homebrew: { packages: ["lcov"], update: true } } - script: .ci/build_coverage.sh diff --git a/CMakeLists.txt b/CMakeLists.txt index 4a05224..c37c718 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -3,6 +3,8 @@ cmake_minimum_required(VERSION 3.8 FATAL_ERROR) if(NOT DEFINED PROJECT_NAME) set(BUILD_AS_STANDALONE ON) +else() + set(BUILD_AS_STANDALONE OFF) endif() project(curly.hpp) @@ -74,13 +76,34 @@ target_include_directories(${PROJECT_NAME} target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_17) +target_compile_options(${PROJECT_NAME} + PRIVATE + $<$,$>: + -Wno-covered-switch-default + -Wno-disabled-macro-expansion + -Wno-exit-time-destructors + -Wno-global-constructors + -Wno-switch-enum>) + +target_compile_options(${PROJECT_NAME} + PUBLIC + $<$,$>: + -Wno-c++98-compat-pedantic + -Wno-ctad-maybe-unsupported + -Wno-padded + -Wno-unknown-warning-option + -Wno-weak-vtables>) + target_compile_options(${PROJECT_NAME} PRIVATE $<$: /W4> PRIVATE - $<$,$,$>: - -Wall -Wextra -Wpedantic>) + $<$: + -Wall -Wextra -Wpedantic> + PRIVATE + $<$,$>: + -Weverything -Wconversion>) # # dependencies diff --git a/README.md b/README.md index f3f7d27..41906e5 100644 --- a/README.md +++ b/README.md @@ -2,26 +2,26 @@ > Simple cURL C++17 wrapper -[![travis][badge.travis]][travis] -[![appveyor][badge.appveyor]][appveyor] +[![linux][badge.linux]][linux] +[![darwin][badge.darwin]][darwin] +[![windows][badge.windows]][windows] [![codecov][badge.codecov]][codecov] [![language][badge.language]][language] [![license][badge.license]][license] -[![paypal][badge.paypal]][paypal] -[badge.travis]: https://img.shields.io/travis/BlackMATov/curly.hpp/main.svg?logo=travis -[badge.appveyor]: https://img.shields.io/appveyor/ci/BlackMATov/curly-hpp/main.svg?logo=appveyor -[badge.codecov]: https://img.shields.io/codecov/c/github/BlackMATov/curly.hpp/main.svg?logo=codecov -[badge.language]: https://img.shields.io/badge/language-C%2B%2B17-yellow.svg -[badge.license]: https://img.shields.io/badge/license-MIT-blue.svg -[badge.paypal]: https://img.shields.io/badge/donate-PayPal-orange.svg?logo=paypal&colorA=00457C +[badge.darwin]: https://img.shields.io/github/workflow/status/BlackMATov/curly.hpp/darwin/main?label=Xcode&logo=xcode +[badge.linux]: https://img.shields.io/github/workflow/status/BlackMATov/curly.hpp/linux/main?label=GCC%2FClang&logo=linux +[badge.windows]: https://img.shields.io/github/workflow/status/BlackMATov/curly.hpp/windows/main?label=Visual%20Studio&logo=visual-studio +[badge.codecov]: https://img.shields.io/codecov/c/github/BlackMATov/curly.hpp/main?logo=codecov +[badge.language]: https://img.shields.io/badge/language-C%2B%2B17-yellow +[badge.license]: https://img.shields.io/badge/license-MIT-blue -[travis]: https://travis-ci.org/BlackMATov/curly.hpp -[appveyor]: https://ci.appveyor.com/project/BlackMATov/curly-hpp +[darwin]: https://github.com/BlackMATov/curly.hpp/actions?query=workflow%3Adarwin +[linux]: https://github.com/BlackMATov/curly.hpp/actions?query=workflow%3Alinux +[windows]: https://github.com/BlackMATov/curly.hpp/actions?query=workflow%3Awindows [codecov]: https://codecov.io/gh/BlackMATov/curly.hpp -[language]: https://en.wikipedia.org/wiki/C%2B%2B14 +[language]: https://en.wikipedia.org/wiki/C%2B%2B17 [license]: https://en.wikipedia.org/wiki/MIT_License -[paypal]: https://www.paypal.me/matov [curly]: https://github.com/BlackMATov/curly.hpp @@ -38,7 +38,7 @@ ## Requirements - [gcc](https://www.gnu.org/software/gcc/) **>= 7** -- [clang](https://clang.llvm.org/) **>= 5.0** +- [clang](https://clang.llvm.org/) **>= 7** - [msvc](https://visualstudio.microsoft.com/) **>= 2017** ## Installation @@ -199,7 +199,7 @@ public: : stream_(filename, std::ofstream::binary) {} std::size_t write(const char* src, std::size_t size) override { - stream_.write(src, size); + stream_.write(src, static_cast(size)); return size; } private: @@ -229,7 +229,7 @@ public: } std::size_t upload(char* dst, std::size_t size) override { - stream_.read(dst, size); + stream_.read(dst, static_cast(size)); return size; } private: diff --git a/sources/curly.hpp/curly.cpp b/sources/curly.hpp/curly.cpp index 213ce54..358d3e3 100644 --- a/sources/curly.hpp/curly.cpp +++ b/sources/curly.hpp/curly.cpp @@ -11,14 +11,6 @@ #include #include -#ifndef NOMINMAX -# define NOMINMAX -#endif - -#ifndef WIN32_LEAN_AND_MEAN -# define WIN32_LEAN_AND_MEAN -#endif - #include // ----------------------------------------------------------------------------- diff --git a/untests/CMakeLists.txt b/untests/CMakeLists.txt index 5129ef8..2240052 100644 --- a/untests/CMakeLists.txt +++ b/untests/CMakeLists.txt @@ -25,11 +25,19 @@ target_link_libraries(${PROJECT_NAME} curly.hpp) target_compile_options(${PROJECT_NAME} PRIVATE - $<$: - /W4> + $<$,$>: + -Wno-zero-as-null-pointer-constant>) + +target_compile_options(${PROJECT_NAME} PRIVATE - $<$,$,$>: - -Wall -Wextra -Wpedantic>) + $<$: + /WX /W4> + PRIVATE + $<$: + -Werror -Wall -Wextra -Wpedantic> + PRIVATE + $<$,$>: + -Werror -Weverything -Wconversion>) add_test(${PROJECT_NAME} ${PROJECT_NAME}) diff --git a/untests/curly_tests.cpp b/untests/curly_tests.cpp index 53d3e37..242e037 100644 --- a/untests/curly_tests.cpp +++ b/untests/curly_tests.cpp @@ -1115,7 +1115,7 @@ TEST_CASE("curly_examples") { } SUBCASE("Request Callbacks") { - auto request = net::request_builder("http://www.httpbin.org/get") + auto req = net::request_builder("http://www.httpbin.org/get") .callback([](net::request request){ if ( request.is_done() ) { auto response = request.take(); @@ -1125,7 +1125,7 @@ TEST_CASE("curly_examples") { } }).send(); - request.wait_callback(); + req.wait_callback(); // Status code: 200 } @@ -1137,7 +1137,7 @@ TEST_CASE("curly_examples") { : stream_(filename, std::ofstream::binary) {} std::size_t write(const char* src, std::size_t size) override { - stream_.write(src, size); + stream_.write(src, static_cast(size)); return size; } private: @@ -1164,7 +1164,7 @@ TEST_CASE("curly_examples") { } std::size_t read(char* dst, std::size_t size) override { - stream_.read(dst, size); + stream_.read(dst, static_cast(size)); return size; } private: